refactor(core): Move set freeday colors to core#86
Conversation
|
First of all thank you for contribution. It becomes helpful. I don't really see why it should be inside a core. If you want to hook whenever color is given from "jwp_freeday" module it can be improved by adding a forward on "jwp_freeday" module instead of modifying core each time. Also inside that module you can override coloring of T team. |
|
Then yes, it would be great to have a forward to install FreeDay inside the "jwp_freeday" plugin itself. |
|
And by this logic, it makes sense to remove the installation freeday from the core, if we set the colors in a separate plugin, which is not logical. |
|
I think better would be to completely remove 'freeday' logic from core. Core doesn't need to be dependent on 'freeday' module. Instead modules what are using 'freeday' functions may depend on 'jwp_freeday' itself. It will make Core simplier. Natives can be kept and extended in 'freeday' module. Maybe it will be a little harsh, but in a perspective it is a good decision. |
|
It would be great |
|
These natives might be moved to their corresponding modules. |
Думаю правильнее избавиться от установки цветов и convarов FreeDay'а в отдельном плагине, когда в ядре у нас есть основная функция для установки FreeDay.
С текущей реализацией, если мы хотим выдавать игрокам FreeDay, то нам надо тянуть convarы с собой, что не очень то круто.
У меня были кейсы: