Skip to content

Removing 'Download Resume' from navbar #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thompson-Jason merged 3 commits into from
Dec 16, 2025
Merged

Removing 'Download Resume' from navbar #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af84eb5
chore: update next.js to version 14.2.35 and related dependencies in …
Thompson-Jason Dec 14, 2025
657e738
Merge branch 'develop' of github.com:Thompson-Jason/Personal-Website …
Thompson-Jason Dec 14, 2025
f2af838
chore: comment out resume download link in Navbar component
Thompson-Jason Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/production-build-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ jobs:
- uses: jongwooo/next-cache@v1
- name: Install NPM dependencies
run: npm install
- name: Bundle .env file
run: touch .env; echo "NEXT_PUBLIC_SERVICE_ID = ${{secrets.NEXT_PUBLIC_SERVICE_ID}}" >> .env; echo "NEXT_PUBLIC_TEMPLATE_ID = ${{secrets.NEXT_PUBLIC_TEMPLATE_ID}}" >> .env; echo "NEXT_PUBLIC_PUBLIC_KEY = ${{secrets.NEXT_PUBLIC_PUBLIC_KEY}}" >> .env
- name: Build project assets
run: npm run build
- name: Cache out directory
Expand Down
102 changes: 71 additions & 31 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@fortawesome/react-fontawesome": "^0.2.2",
"framer-motion": "^11.2.10",
"gray-matter": "^4.0.3",
"next": "14.2.35",
"next": "^14.2.35",
"react": "^18",
"react-dom": "^18",
"react-typed": "^2.0.12"
Expand Down
4 changes: 2 additions & 2 deletions src/components/navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,13 @@ const Navbar = () => {
</Link>
</div>
<div className="hidden md:flex gap-4">
<a
{/* <a
href="/resume.pdf"
download="resume.pdf"
className="flex justify-center items-center rounded py-1 px-2 bg-primary-accent text-primary-secondary text-sm font-semibold hover:text-primary-accent hover:bg-primary-hover transition-colors duration-200"
>
Download Resume
</a>
</a> */}
<Link href="https://github.com/Thompson-Jason" target="_blank">
<FontAwesomeIcon
icon={faGithub}
Expand Down