fix(analytics-aggregator): increment GlobalStats.total_campaigns on first impression (#720) - #736
Open
Sendi0011 wants to merge 1 commit into
Conversation
…irst impression for each campaign Record a campaign in GlobalStats when its first impression is recorded, so total_campaigns reflects the number of distinct campaigns with analytics data instead of always returning 0. Tracks newness by checking if total_impressions == 0 before the increment — no extra storage key needed since CampaignAnalytics is only created via record_impression. Closes ThinkLikeAFounder#720
|
@Sendi0011 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes always returning 0 by incrementing it the first time analytics are recorded for a new campaign.
Problem
was initialized to 0 in and never incremented by any of the recording functions (, , ). always returned regardless of how many campaigns had analytics data.
Fix
In , capture whether the campaign is new ( before incrementing) and increment accordingly. This is safe because is only created via , so checking reliably detects first-time campaigns without needing an extra storage key.
Changes
Test Coverage
Closes #720