Skip to content

fix(workspaces): make upload name resolution and insert atomic #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
posthog wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −6
Draft

fix(workspaces): make upload name resolution and insert atomic #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/features/workspaces/kernel/workspace-kernel-file-commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,6 @@ export class WorkspaceKernelFileCommands {
const now = Date.now();
const itemId = crypto.randomUUID();
const requestedName = normalizeWorkspaceUploadFileName(input.fileName, descriptor);
const name = this.store.resolveItemName({
itemId,
type: "file",
parentId,
requestedName,
});
const shellPath = getWorkspaceKernelFileShellPath({
itemId,
extension: getWorkspaceFileShellExtension({
Expand All @@ -111,6 +105,19 @@ export class WorkspaceKernelFileCommands {
await this.workspace.writeFileBytes(shellPath, bytes, contentType);
await this.r2.delete(input.objectKey);

// Resolve the collision-free name and INSERT in the same synchronous turn.
// The workspace kernel is a Durable Object, so concurrent uploads only
// interleave at `await` points; keeping name resolution and the insert
// adjacent (no `await` between them) prevents two simultaneous uploads of
// the same filename from both resolving to the same name and colliding on
// the partial unique index (kernel_items.name). See resolveItemName below.
const name = this.store.resolveItemName({
itemId,
type: "file",
parentId,
requestedName,
});

this.sql`
INSERT INTO kernel_items (
id,
Expand Down
Loading