Make cipher checking case-insensitive#1
Merged
Conversation
Owner
|
Hi @Mark-H, This is just a fork I used for a minor contribution last year. Please open up a PR on the upstream repository: https://github.com/splittingred/FileLister instead. I'm going to remove the repo by the end of next week. Thanks for reminding me it was still out there |
Author
|
This PR builds upon your contribution, which has not been accepted upstream, which is why I sent it here instead. |
Owner
|
Thanks @Mark-H, I had no idea my PR wasn't accepted. I don't really know how to test this code any more, but when I look at your commit, it looks pretty straightforward and the feature makes sense. I appreciate your work. Guess I'll keep this repo around for a little bit longer then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working for a client, they experienced an issue where the cipher methods were all returned in lowercase while the requested $cipher is specified in uppercase. By uppercasing them all, FileLister works again, and threw in an extra log message for bonus points.