Skip to content

Make cipher checking case-insensitive#1

Merged
ThijsFeryn merged 1 commit into
ThijsFeryn:mcrypt_to_opensslfrom
Mark-H:patch-1
Jun 5, 2020
Merged

Make cipher checking case-insensitive#1
ThijsFeryn merged 1 commit into
ThijsFeryn:mcrypt_to_opensslfrom
Mark-H:patch-1

Conversation

@Mark-H

@Mark-H Mark-H commented Jun 5, 2020

Copy link
Copy Markdown

Working for a client, they experienced an issue where the cipher methods were all returned in lowercase while the requested $cipher is specified in uppercase. By uppercasing them all, FileLister works again, and threw in an extra log message for bonus points.

@ThijsFeryn

Copy link
Copy Markdown
Owner

Hi @Mark-H,

This is just a fork I used for a minor contribution last year. Please open up a PR on the upstream repository: https://github.com/splittingred/FileLister instead.

I'm going to remove the repo by the end of next week. Thanks for reminding me it was still out there ☺️

@ThijsFeryn ThijsFeryn closed this Jun 5, 2020
@Mark-H

Mark-H commented Jun 5, 2020

Copy link
Copy Markdown
Author

This PR builds upon your contribution, which has not been accepted upstream, which is why I sent it here instead.

@ThijsFeryn ThijsFeryn reopened this Jun 5, 2020
@ThijsFeryn
ThijsFeryn merged commit 3a0f0cd into ThijsFeryn:mcrypt_to_openssl Jun 5, 2020
@ThijsFeryn

Copy link
Copy Markdown
Owner

Thanks @Mark-H, I had no idea my PR wasn't accepted.

I don't really know how to test this code any more, but when I look at your commit, it looks pretty straightforward and the feature makes sense.

I appreciate your work. Guess I'll keep this repo around for a little bit longer then.

@Mark-H
Mark-H deleted the patch-1 branch April 24, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants