feat(agent-install): register Hermes and Claude MCPs - #74
Merged
Conversation
sjungwon03-ai
self-requested a review
July 29, 2026 02:32
Member
Author
|
Re-review corrections in f861d5a:
Test-first evidence:
|
sjungwon03-ai
approved these changes
Jul 29, 2026
sjungwon03-ai
left a comment
Member
There was a problem hiding this comment.
Review — APPROVE
Reviewed head f861d5a. CI checks bundled-engine and docs-and-harness are green on this SHA; e2e is still queued but the change is fully covered by 7 dedicated unit tests and 140 regression tests.
What looks good
- Receipt-gated, secret-free CLI registration — Hermes and Claude Code adapters only run after an install receipt is consumed; no
.envvalues or environment secrets enter the CLI arguments. - Compensating rollback on every failure path — add-failure, verification-failure, and Claude unhealthy-discovery all trigger
remove; batch rollback also handles CLI targets via_remove_cli_target. - Exact Claude name matching — the
re.compile(rf"^\s*{re.escape(spec.name)}\s*:")pattern prevents prefix false-positives (e.g.petstore-mcp-oldno longer passes). - Complete argument forwarding —
*spec.argspreserves trailing MCP arguments such as--enable-source-maps. - Test-first evidence — 7 tests cover receipt gating, official CLI argument shape, unhealthy rollback, name-prefix rejection, add-failure compensation, argument preservation, and verification-failure rollback.
Minor observations (non-blocking)
- The
e2eworkflow is still queued; consider re-checking once it completes. - The task brief still shows
Status: in-progressand unchecked verification boxes — cosmetic only.
No correctness, security, or API-contract issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes mcp testand Claude Code through a connectedclaude mcp listentryVerification
python3 -m unittest skills/api-to-typemcp/tests/test_cli_agent_adapters.py -v— 4 passedpython3 -m unittest discover -s skills/api-to-typemcp/tests -p 'test_*.py' -q— 137 passedpython3 .agents/scripts/test_validate_docs.py— 8 passedpython3 .agents/scripts/test_workspace.py— 3 passedpython3 .agents/scripts/validate_docs.pypython3 .agents/scripts/test_skill_release.py— 15 passedpython3 -m py_compile .agents/scripts/*.py skills/api-to-typemcp/scripts/*.pygit diff --checkCloses #73