murray matches#262
Conversation
tmess
commented
Jun 22, 2026
tmess
commented
- Matches in P2/murray and P2/stepguard
- Some updated mangled names in symbol_addrs.txt
- A few new OIDs added
Some updated mangled names in symbol_addrs.txt A few new OIDs added
TheOnlyZac
left a comment
TheOnlyZac
left a comment
There was a problem hiding this comment.
Thanks so much for the PR! Some of these functions have a pretty interesting structure. Before merging I just want to make some cosmetic/style changes for consistency, mainly putting the curly braces on a new line. I'm happy to take care of it myself though, I'll have time tomorrow.
|
Fixed formatting differences, and changed to use the MSGID enum. Thanks for taking a look. |
TheOnlyZac
left a comment
TheOnlyZac
left a comment
There was a problem hiding this comment.
Fixed formatting differences, and changed to use the MSGID enum. Thanks for taking a look.
No problem, thank you again! I gave it one more look with the formatting changes, and spotted a couple more minor things I would want to tweak before merging. Again, I don't mind taking care of them before I merge later today if you don't have time.
|
Done, simple enough for me to do, appreciate it again. |
TheOnlyZac
left a comment
TheOnlyZac
left a comment
There was a problem hiding this comment.
Perfect, thanks! One last question, I just have to ask since you forked the repo before the license was added, do you agree to license your contributions under CC0 1.0 Universal?
|
Also, let me know your Discord username if you would like the Decomp Contributor role in the server. |
|
I agree |
2 participants
