Skip to content

Wip translations#326

Open
Crouch87 wants to merge 2 commits into
TheNAF:masterfrom
Crouch87:wip-translations
Open

Wip translations#326
Crouch87 wants to merge 2 commits into
TheNAF:masterfrom
Crouch87:wip-translations

Conversation

@Crouch87

Copy link
Copy Markdown

Hello,
Added French translations to all translations files (except team creator, impossible to create new class for translation at the moment)
Modified the class_hmtlout file to use the translations for the main menu

French translations, work still in progress
Main menu still not fully translated
Team creator module should be edited to use translations class
@vanhu42

vanhu42 commented Oct 1, 2020

Copy link
Copy Markdown

Great job, thanks !
It looks like you did some translations in a different way than in my previous french updates (I was not sure of some :) ), at least "Pertes totales de l'équipe" still seems to me to be a bad translation, as it is most of the time undestood as "casualities of MY team", when it is in fact "tcas", which is "casualities I did to the other team".
I proposed "Sorties totales faites par l'équipe" as replacement.

@Crouch87

Crouch87 commented Oct 4, 2020

Copy link
Copy Markdown
Author

Thanks, there is still a lot to review I think, I mostly updated empty fields, the translations.xml files from the modules and changed the class_hmtlout file to use the translations.
Concerning the already translated fields, I didn't check all translations, just made (quickly) sure there was no typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants