Skip to content

[Bugfix] Fix handling of language formatting with auto-formatter. - #137

Open
Dirius77 wants to merge 2 commits into
TheDenSS14:masterfrom
Dirius77:radio-formatting
Open

[Bugfix] Fix handling of language formatting with auto-formatter.#137
Dirius77 wants to merge 2 commits into
TheDenSS14:masterfrom
Dirius77:radio-formatting

Conversation

@Dirius77

Copy link
Copy Markdown
Collaborator

About the PR

Fixed it so that dialog color formatting from the denu is still preserved when languages colors are involved (such as over the radio).

Why / Balance

It was bugged before.

Technical details

Tweaked the way that tags are grouped back together, also makes the auto-formatter position tags inside quotes so that languages correctly associates them with dialog.

Test plan

Enter the game, send a complex message (Something starting with ! and including both an emote and dialog tongues in quotes) with and without denu turned on, and observe that the text inside the quotes correctly changes color.

Media

image

Requirements

  • I have read and am following the Macrocosm Pull Request Conventions.
  • I have tested this pull request and written instructions on how to test it.
  • I have added media to this PR or it does not require an in-game showcase.

Licensing

  • All code in this pull request can be licensed to MIT.
  • (OPTIONAL) I give permission to seeing this feature upstreamed to Macrocosm in the future.

Breaking changes

Changelog

Comment thread Content.Server/_DEN/Chat/Systems/ChatSystem.Language.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants