[port] Big hair markings batch - #134
Open
yesteryuri wants to merge 10 commits into
Open
Conversation
Contributor
|
RSI Diff Bot; head commit ec0fc93 merging into b44622c Resources/Textures/_ADT/Mobs/Customization/custom.rsi
Resources/Textures/_ADT/Mobs/Customization/hair.rsi
Resources/Textures/_Corvax/Mobs/Customization/human_facial_hair.rsi
Resources/Textures/_Corvax/Mobs/Customization/human_hair.rsi
Resources/Textures/_DEN/Mobs/Customization/Hair/haircepha.rsi
Resources/Textures/_DEN/Mobs/Customization/Hair/hairdoppler.rsi
Resources/Textures/_DV/Mobs/Customization/hair.rsi
Resources/Textures/_EE/Mobs/Customization/human_hair.rsi
Resources/Textures/_EE/Mobs/Customization/z_human_facial_hair.rsi
Resources/Textures/_Goobstation/Mobs/Customization/human_hair.rsi
Resources/Textures/_Impstation/Mobs/Customization/headcovers.rsi
Resources/Textures/_Impstation/Mobs/Customization/human_hair.rsi
Resources/Textures/_Nuclear14/Mobs/Customization/hair.rsi
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




















































































































































































































































































About the PR
Ports 291 markings from prebase, various servers of origin. All humanoid hairs. I also grabbed facial hair markings along the way. A few non hair markings that were bundled in the same RSI have also been included
Why / Balance
Customization
BTW two nuclear14 markings were commented out on prebase so I elected to also comment them out but write their protos and ftl so they can be enabled. Radiation and Tunnel Snake. I don't see a reason why they're commented out to be honest.
Technical details
Various RSI from prebase have been placed in the corresponding textures folder of origin, and new DEN MIT yaml has been written. ID names remain consistent, as well as ftl names for searchability, but I've added all of the state names to the ftl too.
The added tattoo markings use unshaded layering formatted as macro examples are.
List of RSIs, I've marked them as claimed on the coordination spreadsheet:
_ADT
-custom.rsi (this included several facial hair and tattoo markings)
-hair.rsi
_Corvax
-human_facial_hair.rsi
-human_hair.rsi
_DEN
-haircepha.rsi
-hairdoppler.rsi (I rewrote this copyright to include as many original artists as I could find and have accurate commits as far back as I could find on the various servers they were ported from)
-mera.rsi
_DV
-hair.rsi (something like 4 or 5 hairs in this RSI were identical to upstream hair not even shaded diff, I deleted them)
_EE
-human_hair.rsi
-z_human_facial_hair.rsi
_Goobstation
-human_hair.rsi
_Impstation
-headcovers.rsi (vox and reptilian markings in their own ymls)
-human_hair.rsi
_Nuclear14
-hair.rsi
Test plan
golobby
select a species with the markings and peruse the painfully long lists
(human, reptilian, vox)
check color if you want to see the state name ftls worked
change gender for the like 4 chest tattoos
go ingame with an unshaded marking and walk into the darkness naked
after each batch i did go through and check that the markings i added got in there good luck out there
Media
Requirements
Licensing
( disclaimer that this would be annoying with dupe IDs for imp. i tried to separate commits for cherry-pick warriors )
Breaking changes
I don't think so
Changelog
🆑