Skip to content

Handle inverted requirements correctly and update UI - #128

Merged
portfiend merged 1 commit into
TheDenSS14:masterfrom
Dirius77:invert-traits
Aug 4, 2026
Merged

Handle inverted requirements correctly and update UI#128
portfiend merged 1 commit into
TheDenSS14:masterfrom
Dirius77:invert-traits

Conversation

@Dirius77

@Dirius77 Dirius77 commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

About the PR

Made it so that the Inverted setting in requirements applies to their CheckRequirements logic instead of just their reason text. Fixes #127

Also updated the trait UI to grey out and disable traits your requirements don't match for.

Why / Balance

Bugfix + UI Clarity

Technical details

It's a bool. Changed SetInvalid to a more generic UpdateAppearance function that handles the different appearances now.

Test plan

I used the traits from the blood PR to test this, but:
Try to select a trait you can't.
Select one you can.
Switch to a species that wouldn't be able to select that trait.
Verify that you can still UNselect it.

Media

2026-07-08_19-17-57.mp4

Requirements

  • I have read and am following the Macrocosm Pull Request Conventions.
  • I have tested this pull request and written instructions on how to test it.
  • I have added media to this PR or it does not require an in-game showcase.

Licensing

  • All code in this pull request can be licensed to MIT.
  • (OPTIONAL) I give permission to seeing this feature upstreamed to Macrocosm in the future.

Breaking changes

Changelog

@portfiend
portfiend merged commit 6febc7f into TheDenSS14:master Aug 4, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants