Handle inverted requirements correctly and update UI - #128
Merged
Conversation
portfiend
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Made it so that the Inverted setting in requirements applies to their CheckRequirements logic instead of just their reason text. Fixes #127
Also updated the trait UI to grey out and disable traits your requirements don't match for.
Why / Balance
Bugfix + UI Clarity
Technical details
It's a bool. Changed SetInvalid to a more generic UpdateAppearance function that handles the different appearances now.
Test plan
I used the traits from the blood PR to test this, but:
Try to select a trait you can't.
Select one you can.
Switch to a species that wouldn't be able to select that trait.
Verify that you can still UNselect it.
Media
2026-07-08_19-17-57.mp4
Requirements
Licensing
Breaking changes
Changelog