Port feroxi markings from den1 - #120
Open
kipdotnet wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
S: Needs Review
size/M
S: Untriaged
Changes: No C#
Changes: Sprites
labels
Contributor
|
RSI Diff Bot; head commit a076168 merging into b9f3066 Resources/Textures/_DV/Mobs/Customization/Feroxi/body_markings.rsi
Resources/Textures/_DV/Mobs/Customization/Feroxi/ear_markings.rsi
Resources/Textures/_DV/Mobs/Customization/Feroxi/snout_markings.rsi
Resources/Textures/_DV/Mobs/Customization/Feroxi/tail_markings.rsi
|
Contributor
|
nice changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Ports the markings for feroxi in line with the standards from https://docs.eggware.social/iNP7z3a5TOGDlKmFSaGv5g
Why / Balance
huck asked me nicely
Technical details
ports markings from den1 in the format outlined, edits the yaml so that it works, sprites and locale are unchanged.
notably the original involved BaseMarkingTail, which doesnt exist (nor does marking parenting, even) so I noted that in comments and redefined the stuff every prototype instead
Test plan
Feroxi arent real! Yet! so use a human urist and the admin tricks marking editor with no restrictions to test them
Media
Requirements
Licensing
I dont think I can give this since its a DV port. License header does specify MIT is okay though
Breaking changes
Changelog
🆑fortnite