Skip to content

feat(i18n): complete Spanish translations#122

Open
JRLK0 wants to merge 5 commits into
TheCardGoat:mainfrom
JRLK0:translations/complete-spanish-localization
Open

feat(i18n): complete Spanish translations#122
JRLK0 wants to merge 5 commits into
TheCardGoat:mainfrom
JRLK0:translations/complete-spanish-localization

Conversation

@JRLK0

@JRLK0 JRLK0 commented Jun 9, 2026

Copy link
Copy Markdown

Summary

  • translate all pending Spanish simulator UI strings
  • translate the remaining Spanish engine log message
  • preserve message keys, placeholders, ICU plural syntax, and game-specific terminology

Validation

  • simulator i18n catalog check
  • localized copy check
  • translation key check
  • simulator and engine Paraglide compilation
  • engine log translation contract check
  • repository pre-commit hook (vp check --fix)

@blocksorg

blocksorg Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Mention Blocks like a regular teammate with your question or request:

@blocks review this pull request
@blocks make the following changes ...
@blocks create an issue from what was mentioned in the following comment ...
@blocks explain the following code ...
@blocks are there any security or performance concerns?

Run @blocks /help for more information.

Workspace settings | Disable this message

@kilo-code-bot

kilo-code-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Code Review Roast 🔥

Verdict: 0 Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything.

The previous 2 issues (missing accent on "más" and wrong word choice "serie" for array context) have been fixed. All 982 translation pairs preserve placeholders, ICU plural syntax, and game terminology correctly.

📊 Overall: Like finding a unicorn in production — I didn't think clean translation PRs existed anymore, but here we are.

Files Reviewed (2 files)
  • packages/lorcana/lorcana-engine/messages/es.json - clean, previous issues resolved
  • packages/lorcana/lorcana-simulator/src/messages/es.json - 922 translation pairs, all placeholders intact

Reviewed by step-3.7-flash · 1,238,371 tokens

@JRLK0

JRLK0 commented Jun 18, 2026

Copy link
Copy Markdown
Author

¿?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant