We're not using runfiles anymore, don't use associated macro define.#371
Open
hzeller wants to merge 1 commit into
Open
We're not using runfiles anymore, don't use associated macro define.#371hzeller wants to merge 1 commit into
hzeller wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the preprocessor macro BAZEL_CURRENT_REPOSITORY with BAZEL_BUILD in app/Main.cc and defines BAZEL_BUILD in the BUILD file. The reviewer notes that @rules_cc//cc/runfiles is still listed in the dependencies of the binary and should be removed to complete the cleanup as described in the pull request.
We used to use runfiles to work with tcl dependencies. Since we don't need that anymore, just add a regular `BAZEL_BUILD` define to choose the behavior in the bazel build and remove the unneeded dependency. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260611-runfile
branch
from
7bb4d4e to
c08d761
Compare
Contributor
Author
|
Can this be merged ? |
Contributor
Author
|
Ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to use runfiles to work with tcl dependencies. Since we don't need that anymore, just add a regular
BAZEL_BUILDdefine to choose the behavior in the bazel build and remove the unneeded dependency.