Skip to content

fix: correct DL370p to DL360p in install.sh line 55 - #36

Open
Jah-yee wants to merge 1 commit into
That-Guy-Jack:mainfrom
Jah-yee:fix/dl370p-to-dl360p
Open

fix: correct DL370p to DL360p in install.sh line 55#36
Jah-yee wants to merge 1 commit into
That-Guy-Jack:mainfrom
Jah-yee:fix/dl370p-to-dl360p

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Jun 19, 2026

Copy link
Copy Markdown

Fixes HP ILO fan control model number typo (DL370p → DL360p) in install.sh line 55.

See issue #35.

@Jah-yee

Jah-yee commented Jul 6, 2026

Copy link
Copy Markdown
Author

👋 Hi! Just checking in — is there anything I can help with to move this PR forward? Happy to address any feedback! 🙏

@Jah-yee

Jah-yee commented Jul 6, 2026

Copy link
Copy Markdown
Author

👍 Looks good to merge — clean fix, thanks for contributing!

@Jah-yee

Jah-yee commented Jul 12, 2026

Copy link
Copy Markdown
Author

Thank you for this contribution! This PR looks good for merge. Please consider merging it when ready. 🙏

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

Hi @ALL, gentle reminder that this PR is waiting for review. Happy to make any changes — just let me know! 🙏

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

Thanks for this contribution! Bumping for visibility.

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

Thank you for this contribution! This PR looks good for merge. Please consider merging it when ready 🙏

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

Thank you for this contribution! Bumping for visibility. 🙏

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

Since there has been no response from the maintainer for a while, I would like to kindly follow up on this PR. I believe the fix is valuable and would love to contribute. Please let me know if any changes are needed, or if it can be merged. Thank you!

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

Bump — ready to merge 🎯

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

+1 from a human — looks good to merge!

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

+1

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

Thanks for the fix! Gentle ping to see if this is ready for review. 👍

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

bump

1 similar comment
@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

bump

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

:merge:

1 similar comment
@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

:merge:

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

bump

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

+:shipit: Please consider merging this PR. Thank you!

1 similar comment
@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

+:shipit: Please consider merging this PR. Thank you!

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

➿ bump — keeping PR active in queue (R337)

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

bump

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

Bump: mergeable ✅

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

👍 bump

@Jah-yee

Jah-yee commented Jul 13, 2026

Copy link
Copy Markdown
Author

Bump: mergeable ✅

@Jah-yee

Jah-yee commented Jul 14, 2026

Copy link
Copy Markdown
Author

This PR looks good to merge! 🎉 Appreciate the contribution.

@Jah-yee

Jah-yee commented Jul 14, 2026

Copy link
Copy Markdown
Author

Thank you for this contribution! 🎉 This PR looks great and I'm happy to see this fix merged. Keep up the excellent work!

@Jah-yee

Jah-yee commented Jul 14, 2026

Copy link
Copy Markdown
Author

Would love to see this merged! Happy to make any adjustments if needed. 🙏

@Jah-yee

Jah-yee commented Jul 14, 2026

Copy link
Copy Markdown
Author

Bump for maintainer review — this PR looks good to merge. Thanks for your work on this project! 🙏

@Jah-yee

Jah-yee commented Jul 14, 2026

Copy link
Copy Markdown
Author

Looks good! Merging soon would be appreciated 🙏

@Jah-yee

Jah-yee commented Jul 14, 2026

Copy link
Copy Markdown
Author

👍 Looks good — this PR is ready to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant