Fix links inside dynamically updated markdown tables#6601
Open
VedK5643 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing!
Link to issue or discussion
#6597
Summary
Fixes #6597.
When Markdown content is updated dynamically (for example via
Markdown.append()), table cells are created usingStaticinstead ofMarkdownTableCellContents.Because
Staticdoesn't implementaction_link(), links inside dynamically updated Markdown tables appear interactive but clicking them has no effect.This change uses
MarkdownTableCellContentsconsistently for dynamically created table cells so that link click events are handled correctly.Changes
StaticwithMarkdownTableCellContentsin the dynamic table rendering path.Testing