Skip to content

defensive get_selection #6470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willmcgugan merged 1 commit into from
Apr 5, 2026
Merged

defensive get_selection #6470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/textual/selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ def extract(self, text: str) -> str:
if not lines:
return ""
if self.start is None:
start_line = 0
start_line_index = 0
start_offset = 0
else:
start_line, start_offset = self.start.transpose
start_line_index, start_offset = self.start.transpose

if self.end is None:
end_line = len(lines)
Expand All @@ -52,18 +52,21 @@ def extract(self, text: str) -> str:
end_line, end_offset = self.end.transpose
end_line = min(len(lines), end_line)

if start_line == end_line:
return lines[start_line][start_offset:end_offset]
if start_line_index == end_line:
return lines[start_line_index][start_offset:end_offset]

selection: list[str] = []
selected_lines = lines[start_line : end_line + 1]
selected_lines = lines[start_line_index : end_line + 1]
if len(selected_lines) >= 2:
first_line, *mid_lines, last_line = selected_lines
selection.append(first_line[start_offset:])
selection.extend(mid_lines)
selection.append(last_line[:end_offset])
else:
return lines[start_line][start_offset:end_offset]
try:
selection.append(lines[start_line_index][start_offset:end_offset])
except IndexError:
pass
return "\n".join(selection)

def get_span(self, y: int) -> tuple[int, int] | None:
Expand Down
Loading