Skip to content

Visual style cache #6372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willmcgugan merged 5 commits into from
Feb 15, 2026
Merged

Visual style cache #6372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06a295a
fix visual style caching
willmcgugan Feb 15, 2026
c4e5bd1
visual style caching
willmcgugan Feb 15, 2026
c1e94c3
snapshit
willmcgugan Feb 15, 2026
b3df3d1
update description of snapshot
willmcgugan Feb 15, 2026
9e196f2
docstring
willmcgugan Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/textual/widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,9 @@ def __init__(
"""A dict that is refreshed when the widget is resized / refreshed."""

self._visual_style: VisualStyle | None = None
"""Cached style of visual."""
self._visual_style_cache_key: int = -1
"""Cache busting integer."""

self._render_cache = _RenderCache(_null_size, [])
# Regions which need to be updated (in Widget)
Expand Down Expand Up @@ -4127,7 +4130,12 @@ def _scroll_update(self, virtual_size: Size) -> None:

@property
def visual_style(self) -> VisualStyle:
if self._visual_style is None:
"""The widget's current style."""
if (
self._visual_style is None
or self._visual_style_cache_key != self.styles._cache_key
):
self._visual_style_cache_key = self.styles._cache_key
background = Color(0, 0, 0, 0)
color = Color(255, 255, 255, 0)

Expand Down
Loading
Loading