trap focus#6202
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a trap_focus() method to DOMNode that allows restricting focus navigation (via Tab key) to a specific container and its descendants. When focus trapping is enabled on a container that contains the currently focused widget, the focus chain is limited to only that container's children.
- Added
DOMNode.trap_focus()method to enable/disable focus trapping - Modified
Screen.focus_chainproperty to respect focus trapping by finding the nearest ancestor with_trap_focus=True - Added comprehensive test coverage for the trap focus functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/textual/dom.py | Added _trap_focus instance variable and trap_focus() method to DOMNode |
| src/textual/screen.py | Modified focus_chain property to limit focus traversal to trapped container |
| tests/test_focus.py | Added test case for trap focus functionality with multiple scenarios |
| CHANGELOG.md | Documented the addition of the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to "trap" the focus. So that tabbing through controls is restricted to the given container. This can be a requirement for something like a modal dialog, which doesn't use a modal screen.