Skip to content

don't ineherit from Static#6041

Merged
willmcgugan merged 4 commits into
mainfrom
prettier-fix
Aug 13, 2025
Merged

don't ineherit from Static#6041
willmcgugan merged 4 commits into
mainfrom
prettier-fix

Conversation

@willmcgugan

@willmcgugan willmcgugan commented Aug 13, 2025

Copy link
Copy Markdown
Member
  • Don't inherit Pretty from Static
  • Renamed Static.renderable to Static.content

@willmcgugan willmcgugan merged commit f76670e into main Aug 13, 2025
21 of 22 checks passed
@willmcgugan willmcgugan deleted the prettier-fix branch August 13, 2025 08:13
@TomJGooding

Copy link
Copy Markdown
Contributor

The Static widget has changed a lot recently so maybe I just haven't kept up, but I don't understand why there's an update method and now a content setter? Is this just for backward compatibility?

You can also get weird results like this:

static = Static("Old content")
static.content = "New content"
assert static.content == "New content"
# AssertionError: assert 'Old content' == 'New content'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants