Skip to content

SelectType must be Hashable#6034

Merged
willmcgugan merged 1 commit into
Textualize:mainfrom
davidfokkema:fix-selecttype-hashable
Aug 12, 2025
Merged

SelectType must be Hashable#6034
willmcgugan merged 1 commit into
Textualize:mainfrom
davidfokkema:fix-selecttype-hashable

Conversation

@davidfokkema

@davidfokkema davidfokkema commented Aug 10, 2025

Copy link
Copy Markdown
Contributor

Because of the internal use of a set for _legal_values, only hashable options are allowed. This makes sure the type checkers correctly flag dictionaries (or lists) being passed as options.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

Because of the internal use of a set for `_legal_values`, only hashable options are allowed.
Comment thread src/textual/widgets/_select.py
Comment thread src/textual/widgets/_select.py
@willmcgugan willmcgugan merged commit eec7e80 into Textualize:main Aug 12, 2025
23 checks passed
@willmcgugan

Copy link
Copy Markdown
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants