Skip to content

Rename test to avoid name duplication#6033

Merged
willmcgugan merged 1 commit into
Textualize:mainfrom
davidfokkema:fix-duplicate-named-test
Aug 12, 2025
Merged

Rename test to avoid name duplication#6033
willmcgugan merged 1 commit into
Textualize:mainfrom
davidfokkema:fix-duplicate-named-test

Conversation

@davidfokkema

@davidfokkema davidfokkema commented Aug 10, 2025

Copy link
Copy Markdown
Contributor

Due to duplicate names, one of the tests wasn't run. I didn't add that to the changelog.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

Due to duplicate names, one of the tests wasn't run.
@davidfokkema

Copy link
Copy Markdown
Contributor Author

The CI tests failed on Windows with Python 3.13 with:

FAILED tests/footer/test_footer.py::test_footer_bindings - assert 0 == 1

which is an error I see in at least another workflow run totally unrelated to this PR.

@TomJGooding

Copy link
Copy Markdown
Contributor

That failing test has been very flaky in CI recently - my second attempt to fix this in PR #6032

@davidfokkema

Copy link
Copy Markdown
Contributor Author

That failing test has been very flaky in CI recently - my second attempt to fix this in PR #6032

I see! Thanks for chiming in, I was confused for a bit.

@willmcgugan willmcgugan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. Must have been a copy and paste booboo

@willmcgugan willmcgugan merged commit 879ee22 into Textualize:main Aug 12, 2025
37 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants