Skip to content

test(footer): add pauses for flaky test in CI#6022

Merged
willmcgugan merged 3 commits into
Textualize:mainfrom
TomJGooding:test-footer-add-pauses-for-flaky-test
Aug 6, 2025
Merged

test(footer): add pauses for flaky test in CI#6022
willmcgugan merged 3 commits into
Textualize:mainfrom
TomJGooding:test-footer-add-pauses-for-flaky-test

Conversation

@TomJGooding

@TomJGooding TomJGooding commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

Hopefully resolves #6020 unless I've just been lucky with these CI runs!

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@TomJGooding TomJGooding marked this pull request as ready for review August 6, 2025 13:52
@willmcgugan

Copy link
Copy Markdown
Member

Thanks. Fingers crossed that does it.

Puzzled why wait_for_refresh didn't fix it.

@willmcgugan willmcgugan merged commit ac1d3ef into Textualize:main Aug 6, 2025
23 checks passed
@TomJGooding

Copy link
Copy Markdown
Contributor Author

Fingers crossed! No idea why this seems to only fail on Windows 11 either.

I just assumed wait_for_refresh doesn't wait for pending messages unlike pilot.pause?

@TomJGooding TomJGooding deleted the test-footer-add-pauses-for-flaky-test branch August 6, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test_footer_bindings test in CI

2 participants