Fix gh-5894: Mouse capture issues on Windows#6018
Merged
Merged
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5894 reports that when running a Textual app under Windows Terminal with
mouse=False, the console gets polluted with garbage characters when the mouse is moved during and after the app's execution.The issue is caused by an extraneous line in Textual's Windows driver. That line enables mouse support regardless of the
mouseflag. However, mouse inputs are not handled whenmouse=False; nor does the clean-up routine disable the mouse support whenmouse=False. As a result, control sequences that encode mouse events are treated as regular input, and the screen gets polluted.This PR fixes the issue by removing that extraneous line.