Skip to content

feat(highlight): use theme text colors#5970

Merged
willmcgugan merged 1 commit into
Textualize:mainfrom
TomJGooding:feat-highlight-use-theme-text-colors
Jul 18, 2025
Merged

feat(highlight): use theme text colors#5970
willmcgugan merged 1 commit into
Textualize:mainfrom
TomJGooding:feat-highlight-use-theme-text-colors

Conversation

@TomJGooding

Copy link
Copy Markdown
Contributor

The new highlight module for syntax highlighting currently uses the 'base' theme colors. Perhaps this was intentional, but to my eye this makes the colors in Markdown code blocks so prominent that they feel a bit out of place.

This updates the highlight theme to instead use the dedicated theme text colors, which I think looks more consistent.

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

The new `highlight` module for syntax highlighting currently uses the
'base' theme colors. Perhaps this was intentional, but to my eye this
makes the colors in `Markdown` code blocks so prominent that they feel
a bit out of place.

This updates the highlight theme to instead use the dedicated theme text
colors, which I think looks more consistent.
@willmcgugan

Copy link
Copy Markdown
Member

I'd forgotten about those. Yeah, that looks a little kinder on the eyes.

@TomJGooding

Copy link
Copy Markdown
Contributor Author

Here's a side-by-side comparison of the Textual demo to demonstrate:

Before After
image image

@TomJGooding

TomJGooding commented Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

I'd forgotten about those. Yeah, that looks a little kinder on the eyes.

I'm glad you agree as honestly I was a bit hesitant to make this PR. Probably I'm just a bit fixated on theme colors after working on my theme editor!

I'm not really a fan of the new inline code colors either, but that's obviously just personal taste.

@willmcgugan willmcgugan merged commit a605a5a into Textualize:main Jul 18, 2025
23 checks passed
@willmcgugan

Copy link
Copy Markdown
Member

How would you improve the inline code style?

@TomJGooding

TomJGooding commented Jul 18, 2025

Copy link
Copy Markdown
Contributor Author

@willmcgugan What was wrong with the old colors? I'm used to inline code looking like this so the change to warning colors just looks strange to me.

@TomJGooding TomJGooding deleted the feat-highlight-use-theme-text-colors branch July 18, 2025 09:51
@willmcgugan

Copy link
Copy Markdown
Member

Previous version was bold and dim, IIRC. I didn't feel it had enough emphasis. And obviously it already has a monospace font, so there was nothing to say this was code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants