Skip to content

Fix keyline glitch #5936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willmcgugan merged 2 commits into from
Jul 7, 2025
Merged

Fix keyline glitch #5936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4ef270
Fix keyline glitch
willmcgugan Jul 7, 2025
4846a3b
changelog
willmcgugan Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Potential breaking change: Changed default `query_one` and `query_exactly_one` search to breadth first https://github.com/Textualize/textual/pull/5930
- Cursor is now visible by default when in read only mode (restoring pre 3.6.0 behavior) https://github.com/Textualize/textual/pull/5934

### Fixed

- Fixed issue with Keylines not scrolling https://github.com/Textualize/textual/pull/5936

## [3.6.0] - 2025-07-06

### Fixed
Expand Down
4 changes: 4 additions & 0 deletions src/textual/widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4284,6 +4284,10 @@ def _check_refresh(self) -> None:
else:
if self._scroll_required:
self._scroll_required = False
if self.styles.keyline[0] != "none":
# TODO: Feels like a hack
# Perhaps there should be an explicit mechanism for backgrounds to refresh when scrolled?
self._set_dirty()
screen.post_message(messages.UpdateScroll())
if self._repaint_required:
self._repaint_required = False
Expand Down
Loading
Loading