Simple valid empty fix#5891
Closed
holdenweb wants to merge 2 commits into
Closed
Conversation
The new test at tests/input/test_input_validation.py::test_valid_empty failed until the sequence of operations in the Input.validate function was refactored. Existing test continue to pass.
holdenweb
commented
Jun 25, 2025
|
|
||
| if self.valid_empty and not value: | ||
| # If no validators are supplied, and therefore no validation occurs, we return None. | ||
| if not self.validators: |
Contributor
Author
There was a problem hiding this comment.
Since we here have two conditions with the same action, would it overcomplicate the code to elide them? At present I suspect the sequence improves readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the following checklist.
This PR fixes the error that validates an empty input with no validators as valid even though
valid_emptyis False.