Skip to content

Update Widget.set_loading Docstring#5833

Merged
willmcgugan merged 3 commits into
Textualize:mainfrom
ddkasa:fix-set-loading-return-type-docstring
Jun 11, 2025
Merged

Update Widget.set_loading Docstring#5833
willmcgugan merged 3 commits into
Textualize:mainfrom
ddkasa:fix-set-loading-return-type-docstring

Conversation

@ddkasa

@ddkasa ddkasa commented Jun 2, 2025

Copy link
Copy Markdown
Contributor

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

The original implementation returned an Awaitable which was since then removed. This PR removes the outdated return header from the docstring and adds some minor tweaks.

ddkasa added 3 commits June 2, 2025 10:25
… docstring

This method was updated to use a different mechanism since its original
implementation and the docstring remained unchanged.
@ddkasa ddkasa changed the title Update Widget.set_loading_widget Docstring Update Widget.set_loading Docstring Jun 2, 2025
@willmcgugan willmcgugan merged commit 3483d81 into Textualize:main Jun 11, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants