Skip to content

avoid exposing asyncio.Future directly to api consumers#5765

Open
graingert wants to merge 16 commits into
Textualize:mainfrom
graingert:avoid-exposing-futures-directly-to-consumers
Open

avoid exposing asyncio.Future directly to api consumers#5765
graingert wants to merge 16 commits into
Textualize:mainfrom
graingert:avoid-exposing-futures-directly-to-consumers

Conversation

@graingert

@graingert graingert commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

This avoids exposing an 'asyncio.Future' to api consumers - instead returning an awaitable object wrapping an Event and a Result.

  • This should fix an issue where cancellation would result in an invalid state error
  • This work is needed for Feature Suggestions #3 (comment) where asyncio Futures do not work with the trio backend.

Please review the following checklist.

I didn't see any documentation for this feature outside docstrings, it's probably worth a note in the changelog

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@willmcgugan willmcgugan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine in principle. Just some requests.

Comment thread src/textual/app.py Outdated
Comment thread src/textual/screen.py Outdated
Comment thread src/textual/screen.py
Comment thread src/textual/app.py Outdated
Comment thread src/textual/screen.py
@graingert graingert marked this pull request as ready for review May 12, 2025 06:20
@graingert graingert requested a review from willmcgugan May 22, 2025 08:53
Comment thread src/textual/app.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants