led rgb solution by SamDan13 · Pull Request #95 · Tesla-UFMG/ECU

SamDan13 · 2023-03-15T18:56:51Z

No description provided.

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

…ure/led_rgb_new_debug_code

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

…ure/led_rgb_new_debug_code

SamDan13 · 2023-03-19T15:16:05Z

Vídeo do teste do código no LED:
https://user-images.githubusercontent.com/62140716/226185493-d2d8187c-1114-47dc-8066-1e890de47445.mp4

Nesse teste o LED começa antes de entrar em RTD (Piscando Verde - 200ms) em seguida depois de entrar em RTD já da um Soft Error (Pisca Amarelo e Verde - 200ms), depois ainda em RTD responde a um Hard Error (Pisca Vermelho, Azul e Roxo - 1000ms). Sai de RTD por conta do Hard Error e entra em RTD (Verde Fixo).

FelTell

Não vou comentar em todo caso, mas esse código (tanto o antigo, quanto o que vc mexeu) tá cheio de comentários e códigos em português. Traduzir tudo pra inglês.

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

…ure/led_rgb_new_debug_code

FelTell · 2023-05-31T23:42:33Z

No arquivo clang-format-check.yml muda a clang-format-version: '15' para 16. Ele deve até pedir pra formatar outro arquivo, acho que foi o global-definitions.h. O vscode deve ter atualizado a versão do clang-format.
Da merge com a develop tbm por favor

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

github-actions

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

github-actions · 2023-06-11T16:37:10Z

+    message.pattern[0]      = pattern[0];
+    message.pattern[1]      = size_of_pattern > 1 ? pattern[1] : 0;
+    message.pattern[2]      = size_of_pattern > 2 ? pattern[2] : 0;
+    return osMessageQueuePutOverwrite(q_rgb_led_messageHandle, &message, 0);


⚠️ clang-diagnostic-implicit-function-declaration ⚠️
implicit declaration of function osMessageQueuePutOverwrite is invalid in C99

github-actions · 2023-06-11T16:37:10Z

+    } else {
+        return *oldValue;
+    }


⚠️ llvm-else-after-return ⚠️
do not use else after return

Suggested change

} else {

return *oldValue;

}

} return *oldValue;

SamDan13 and others added 30 commits January 17, 2023 16:59

rgb feature 1.0

4d65c17

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

b61b0f6

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

d94c917

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

new rgb function

8485fe9

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

210e6f9

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

new rgb function 1.1

487ff66

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

5936a44

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

new rgb function 1.2

4ad37d6

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

6c8abed

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

new rgb function 1.3

e2c86f6

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

8f74fe6

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

new rgb function 1.4

98b8764

new rgb function 1.4.2

ee7557f

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

432c438

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

new rgb function 1.4.3

fa174a7

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

b60da98

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

possible solution

da7f5e8

Merge branch 'develop' of https://github.com/Tesla-UFMG/ECU into feat…

993b0e4

…ure/led_rgb_new_debug_code

possible solution pt.2

f16376d

possible solution pt.3

578284e

possible changes

36a0b4a

Merge branch 'develop' of https://github.com/Tesla-UFMG/ECU into feat…

f549fc5

…ure/led_rgb_new_debug_code

test chages

badb618

possible solution pt.4

d318228

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

ba3b89b

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

possible solution pt.4

ad8148b

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

48994bc

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

logic test changes & defines added

fde458d

Merge branch 'develop' of https://github.com/Tesla-UFMG/ECU into feat…

1bc9d91

…ure/led_rgb_new_debug_code

final solution

247157e

led rgb solution

3968d88

FelTell requested changes Apr 2, 2023

View reviewed changes

rgb_led_handler.c improvement

2f99c7d

FelTell requested changes Apr 4, 2023

View reviewed changes

Comment thread Core/Inc/util/global_definitions.h Outdated

Comment thread Core/Src/util/initializers.c Outdated

Comment thread Core/Src/leds/rgb_led_handler.c Outdated

Comment thread Core/Src/leds/rgb_led_handler.c Outdated

SamDan13 and others added 3 commits April 5, 2023 09:39

are_messages_available

62a02c8

solved requested changes

ee00b1d

Merge branch 'develop' into feature/led_rgb_new_debug_code

59ed551

github-actions Bot requested changes Apr 12, 2023

View reviewed changes

SamDan13 added 2 commits April 12, 2023 12:19

some fixes

372c961

some fixes

985d01d

github-actions Bot requested changes Apr 12, 2023

View reviewed changes

Comment thread Core/Src/leds/rgb_led_handler.c

SamDan13 added 2 commits April 12, 2023 12:33

format fixes

81a5b13

correcting type of function 'are_messages_available'

438855b

FelTell requested changes Apr 30, 2023

View reviewed changes

resolved requests

2c1e397

github-actions Bot requested changes May 6, 2023

View reviewed changes

Comment thread Core/Inc/leds/rgb_led_handler.h Outdated

SamDan13 added 2 commits May 6, 2023 14:13

resolved requests -- formatting fix

673f50a

resolved requests -- clang-tidy fix

7d36a36

dmrohrs reviewed May 16, 2023

View reviewed changes

Comment thread Core/Src/driver_settings/RTD.c

dmrohrs requested changes May 16, 2023

View reviewed changes

Comment thread Core/Src/driver_settings/RTD.c Outdated

SamDan13 and others added 3 commits May 21, 2023 19:01

RTD.c requests

04315a9

clang-format fixes

8db24a2

Merge branch 'develop' of https://github.com/Tesla-UFMG/ECU into feat…

60052c9

…ure/led_rgb_new_debug_code

dmrohrs and others added 4 commits June 1, 2023 09:58

updating .yml clang-format version

cef562b

formatting global_definitions.h

aa1c879

test function

c0f6038

Merge branch 'feature/led_rgb_new_debug_code' of https://github.com/T…

bfff9f2

…esla-UFMG/ECU into feature/led_rgb_new_debug_code

github-actions Bot requested changes Jun 11, 2023

View reviewed changes

Uh oh!

Conversation

SamDan13 commented Mar 15, 2023

Uh oh!

SamDan13 commented Mar 19, 2023

Uh oh!

FelTell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FelTell commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 11, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Jun 11, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

FelTell commented May 31, 2023 •

edited

Loading