Skip to content

(WIP) Ecu3.0/steering adjusted#76

Open
tarcisiolucas wants to merge 15 commits into
ECU3.0/developfrom
ECU3.0/steering-adjusted
Open

(WIP) Ecu3.0/steering adjusted#76
tarcisiolucas wants to merge 15 commits into
ECU3.0/developfrom
ECU3.0/steering-adjusted

Conversation

@tarcisiolucas

Copy link
Copy Markdown

Mudança da lógica do valor do ganho do volante, utilizando o Teorema de Tales. Retira a necessidade de realizar uma regressão linear para cada calibração. Mudança da lógica para determinar o lado do esterçamento.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment thread Core/Src/sensors/steering.c Outdated

@FelTell FelTell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foi muito comentário já, não se assuste, qualquer coisa pode mandar msg pra mim.

Formate com clang-format.

Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/dynamic_controls/lateral_control.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Inc/sensors/steering.h Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Inc/util/constants.h Outdated
Comment thread Core/Src/sensors/steering.c Outdated

@FelTell FelTell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolva os conflitos

Comment thread Core/Src/dynamic_controls/lateral_control.c Outdated
Comment thread Core/Src/dynamic_controls/lateral_control.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated

@FelTell FelTell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essa foi a última vez que olho PR com conflito, por favor resolva.

Comment thread Core/Inc/util/constants.h Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/dynamic_controls/lateral_control.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment thread Core/Inc/util/constants.h Outdated
Comment thread Core/Inc/util/constants.h Outdated
Comment thread Core/Src/dynamic_controls/lateral_control.c
Comment thread Core/Src/dynamic_controls/lateral_control.c Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment thread Core/Src/dynamic_controls/lateral_control.c Outdated
@luizaaraujo1 luizaaraujo1 requested a review from FelTell June 29, 2022 19:49
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/sensors/steering.c Outdated
Comment thread Core/Src/dynamic_controls/lateral_control.c Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment thread Core/Inc/sensors/steering.h Outdated
@luizaaraujo1 luizaaraujo1 changed the title Ecu3.0/steering adjusted (WIP) Ecu3.0/steering adjusted Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants