Skip to content

Multisig example#2

Open
nvitorovic wants to merge 2 commits into
mainfrom
example/multisig
Open

Multisig example#2
nvitorovic wants to merge 2 commits into
mainfrom
example/multisig

Conversation

@nvitorovic

Copy link
Copy Markdown
Contributor

No description provided.

@nvitorovic nvitorovic requested a review from lucko515 August 16, 2022 09:41
Comment thread multisig-wallet/README.md
@@ -0,0 +1,147 @@
# Web3 Actions + Multisig wallet

This repository shows usage of Web3 Actions running with a simple [multisig wallet](contracts/MultiSigWallet.sol).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of shows I would put demonstrates

Comment thread multisig-wallet/README.md

# Running the example

The Web3 Actions code is located in `web3-actions` folder. You can specify this when running `tenderly actions init`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can specify this when running tenderly actions init. -> Having this sentence immediately after the first one is a bit confusing. Try providing a bit more context here

Comment thread multisig-wallet/README.md
You can use these TX hashes to run Web3 Actions manually from the Dashboard. Skip
to [Deploying Web3 Actions](#3-deploying-web3-actions).

Note: since the contracts are deployed with a pre-defined list of owners, you can simulate transactions, but you can't

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider putting this paragraph as "NOTE" section
Markdow: > Note: ...

**/
const main = async () => {
const testRuntime = new TestRuntime();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, add link to Secrets in W3A documents :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants