docs(skills): clean up 6 makers-agents reference doc defects - #12
Merged
Conversation
Upstream review of edgeone-pages-skills flagged six non-blocking issues that we inherited via the earlier synchronization. All confirmed in this repo; none affect runtime behavior, but they break rendering, links, or runnable examples: - framework-native-patterns.md: three dead links (langchain-route.md, claude-sdk-route.md, platform-conventions.md — none exist). Repoint to the current targets: node-frameworks/langgraph.md, node-frameworks/claude-sdk.md, platform/node-entry.md. - python-frameworks/crewai.md /history handler: signature is handler(context) but the body used ctx.conversation_id (would NameError). Rename to context.conversation_id. - python-frameworks/crewai.md Node/Python compare table: the memory row said "typically replaced by ctx.store" — softer than the body's memory=False hard constraint. Align to "Must be memory=False; cross- turn memory goes through context.store". - python-frameworks/crewai.md See also: drop the empty leading list item. - platform/node-entry.md externalize-packages table: a blockquote line cut the table body, leaving the bcrypt row orphaned outside. Move bcrypt into the table, keep the blockquote after. - capabilities/store.md framework compare table: the Bare model / custom loop cell had an unclosed **, which broke that row's rendering. Close the bold marker. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream review of edgeone-pages-skills flagged six non-blocking issues that we inherited via the earlier synchronization. All confirmed in this repo; none affect runtime behavior, but they break rendering, links, or runnable examples: