Skip to content

docs(skills): clean up 6 makers-agents reference doc defects - #12

Merged
vincentism merged 1 commit into
mainfrom
feat/backend
Aug 13, 2026
Merged

docs(skills): clean up 6 makers-agents reference doc defects#12
vincentism merged 1 commit into
mainfrom
feat/backend

Conversation

@vincentism

Copy link
Copy Markdown
Collaborator

Upstream review of edgeone-pages-skills flagged six non-blocking issues that we inherited via the earlier synchronization. All confirmed in this repo; none affect runtime behavior, but they break rendering, links, or runnable examples:

  • framework-native-patterns.md: three dead links (langchain-route.md, claude-sdk-route.md, platform-conventions.md — none exist). Repoint to the current targets: node-frameworks/langgraph.md, node-frameworks/claude-sdk.md, platform/node-entry.md.
  • python-frameworks/crewai.md /history handler: signature is handler(context) but the body used ctx.conversation_id (would NameError). Rename to context.conversation_id.
  • python-frameworks/crewai.md Node/Python compare table: the memory row said "typically replaced by ctx.store" — softer than the body's memory=False hard constraint. Align to "Must be memory=False; cross- turn memory goes through context.store".
  • python-frameworks/crewai.md See also: drop the empty leading list item.
  • platform/node-entry.md externalize-packages table: a blockquote line cut the table body, leaving the bcrypt row orphaned outside. Move bcrypt into the table, keep the blockquote after.
  • capabilities/store.md framework compare table: the Bare model / custom loop cell had an unclosed **, which broke that row's rendering. Close the bold marker.

Upstream review of edgeone-pages-skills flagged six non-blocking issues
that we inherited via the earlier synchronization. All confirmed in this
repo; none affect runtime behavior, but they break rendering, links, or
runnable examples:

- framework-native-patterns.md: three dead links (langchain-route.md,
  claude-sdk-route.md, platform-conventions.md — none exist). Repoint to
  the current targets: node-frameworks/langgraph.md,
  node-frameworks/claude-sdk.md, platform/node-entry.md.
- python-frameworks/crewai.md /history handler: signature is
  handler(context) but the body used ctx.conversation_id (would
  NameError). Rename to context.conversation_id.
- python-frameworks/crewai.md Node/Python compare table: the memory row
  said "typically replaced by ctx.store" — softer than the body's
  memory=False hard constraint. Align to "Must be memory=False; cross-
  turn memory goes through context.store".
- python-frameworks/crewai.md See also: drop the empty leading list item.
- platform/node-entry.md externalize-packages table: a blockquote line
  cut the table body, leaving the bcrypt row orphaned outside. Move
  bcrypt into the table, keep the blockquote after.
- capabilities/store.md framework compare table: the Bare model / custom
  loop cell had an unclosed **, which broke that row's rendering. Close
  the bold marker.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vincentism
vincentism merged commit a68c4bf into main Aug 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant