Skip to content

Fix Blend adapter admin retargeting#438

Closed
carrion256 wants to merge 1 commit into
spr/refactor/vault-ergonomics/4f330057from
audit/adapter-admin-retarget-a035
Closed

Fix Blend adapter admin retargeting#438
carrion256 wants to merge 1 commit into
spr/refactor/vault-ergonomics/4f330057from
audit/adapter-admin-retarget-a035

Conversation

@carrion256

@carrion256 carrion256 commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the undeployed Blend adapter set_pool and set_vault admin retarget entrypoints
  • delete stale pool_upd / vlt_upd event surface and obsolete setter tests
  • remove justfile recipes that invoked the deleted retarget methods
  • add a source-shape regression that fails if the public retarget ABI/events return

Nexus

  • 81068879-6d1a-460a-b176-bc982fb254cd

Verification

  • RED before fix: cargo test -p templar-soroban-blend-adapter blend_adapter_does_not_expose_admin_retarget_entrypoints -- --nocapture failed on pub fn set_pool
  • GREEN: cargo fmt --all -- --check
  • GREEN: git diff --check
  • GREEN: cargo test -p templar-soroban-blend-adapter -- --nocapture (12 unit + 7 integration passed)
  • GREEN: cargo test -p templar-soroban-runtime --features testutils --lib -- --nocapture (103 passed)
  • GREEN: cargo test -p templar-soroban-runtime --features testutils --test property_tests -- --nocapture (23 passed)
  • GREEN: just -f contract/vault/soroban/justfile size-budget-check (93961 <= 131072)
  • GREEN: source sweep zero matches for Blend adapter retarget methods/events; justfile listing no longer advertises blend-adapter-set-pool / blend-adapter-set-vault

Notes

Contracts are undeployed, so this PR removes the mutable retargeting ABI instead of adding a timelock wrapper around it.


This change is Reviewable

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b2fe410e-be19-4f34-8852-47dea1a416b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch audit/adapter-admin-retarget-a035

Comment @coderabbitai help to get the list of available commands and usage tips.

@carrion256

Copy link
Copy Markdown
Collaborator Author

Superseded by #431, which consolidates the tracker-defined adapter-accounting-and-blend-admin boundary for A-032/A-033/A-034/A-035/A-060. Closing this split draft so auditors have one adapter follow-up PR to review.

@carrion256

Copy link
Copy Markdown
Collaborator Author

Closed as superseded by #431 consolidated adapter-accounting-and-blend-admin PR.

@carrion256 carrion256 closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant