Invincibility stars fix

[QuartzTS]

Trying to fix the invincibility stars, nothing else to say here for now..

[DimensionWarped]

I assume by the fact that this is a draft that you aren't ready for review yet?

[QuartzTS]

I know, but like, should I open it for testing the fix or keep it as a draft till I do smth with the invincibility stars? (Forgot to say this is my first time opening a pull request and contributing to another repository..)

[DimensionWarped]

Oh, generally speaking you wouldn't create a PR until you have some kind of fix actually ready unless you were specifically reaching out to a dev for help which is usually what the drafts are for... that or sharing a fix that you aren't adequately sure of and don't mind tossing over the fence should you disappear for someone else to look at.

[QuartzTS]

Well, I just fixed the scene leak, but I'm also trying to implement the invincibility star effect from Sonic 2, even tho it feels like I might need help at this or smth.. maybe no problem with opening the pull request for testing

[DimensionWarped]

I tried to eyeball an understanding of what happens with the Sonic 2 invincibility star effect, but it's kinda busy so it's hard to tell the exact details of it. I'll try to work with you on it soon.

[Caverns4]

From what I can infer, its actually not as complicated as it looks at least on an outer level. It looks like there are four pairs of stars, each one orbiting Sonic with each one beeing offset by where Sonic was a certain number of frames ago, and then there's a scond part to the efect that essentially just spawns stars at a psuedo-random offset at different set intervals.

[QuartzTS]

Huh, I knew there is more to it.. anyways, here's what I've done so far, It's just 8 rotating particles spinning around the player's position in whatever direction it's in, I've deleted the two star generator nodes and replaced them with rotating particle scenes and tweaked some code, I know it's not much progress and there's nothing much to it, I just need to figure out the animations and how to make it follow the player and other stuff..

2026-06-16.21-34-51.mp4

[QuartzTS]

Okay, so I guess the invincibility stars in Sonic 2 consists of 4 pairs of stars like @Caverns4 said, and they're spinning around the player in whatever direction the player is facing, with the main pair being locked into the player's position while the other pairs trail behind the player (kinda like afterimages or smth idk), and the rotation and animation of the main pair are faster than the trail pairs, so with this, I brought back the two star generators like normal so that they function like a main pair, even tho I still feel like it shouldn't be in the player scene, and I still gotta figure out how to make the trail pairs by instantiating them when the invincibility monitor is destroyed and freeing them when the invincibility effect is finished..

2026-06-22.20-15-57.mp4

Btw, all this made me rethink of the particle system, since I initially asked for a particle rework cuz I thought having multiple particle objects is a bit redundant, and now idk what to do since the invincibility stars doesn't function like a generic particle.. (btw, I guess the invincibility stars effect is the only thing that uses RotatingParticles, so I deleted every other animation in the RotatingParticle scene and kept the invincibility animation, and did the same for the player's star generators)