Fix shop page loading overlay rendering#46
Conversation
- Updated `showLoading` to append the loading overlay to `document.body` instead of the `#shop-items` container. This ensures `position: fixed` behaves correctly and creates a full-screen overlay regardless of parent layout context or CSS transforms. - Created `hideLoading` method to cleanly remove the overlay element by its new ID (`global-loading-overlay`). - Ensured `hideLoading` is called at the end of `fetchItems` (both on success and failure) and prior to creating a new one to prevent duplication. Co-authored-by: TechJeeper <5033913+TechJeeper@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes an issue where the loading spinner on the shop page was confined to a small area and improperly formatted due to its container having a CSS transform property. Appending the element directly to the document body ensures the
position: fixedoverlay properly covers the entire viewport. Cleaned up overlay removal logic as well.PR created automatically by Jules for task 17033873132370283901 started by @TechJeeper