Skip to content

Fix shop category filtering by ensuring type consistency#40

Open
TechJeeper wants to merge 1 commit into
mainfrom
fix-shop-category-filtering-12481817733199219903
Open

Fix shop category filtering by ensuring type consistency#40
TechJeeper wants to merge 1 commit into
mainfrom
fix-shop-category-filtering-12481817733199219903

Conversation

@TechJeeper

Copy link
Copy Markdown
Owner

Fixes category filtering logic on shop.html by parsing Ko-Fi ShopCategoryIds as a Number before checking if it is included in the integer-based kofiCategoryMap.


PR created automatically by Jules for task 12481817733199219903 started by @TechJeeper

The Ko-Fi API sometimes returns `ShopCategoryIds` as strings. However, `kofiCategoryMap` expects integers. This commit adds a `Number(id)` conversion before calling `includes()` in `applyCategoryFilter` so filtering correctly matches type explicitly.

Co-authored-by: TechJeeper <5033913+TechJeeper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant