Skip to content

fix(install): place_config_template backup 变量 bash 3.2 安全 #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigbrother666sh merged 1 commit into from
Jul 21, 2026
Merged

fix(install): place_config_template backup 变量 bash 3.2 安全 #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ place_config_template() {
ui_error "config template 缺失：$tmpl（tarball 损坏？）"
return 1
fi
local need_place=0 reason=""
local need_place=0 reason="" backup=""
if [[ ! -f "$config_path" ]]; then
need_place=1; reason="不存在"
elif [[ "$FORCE_RUNTIME" == "true" ]]; then
Expand All @@ -1165,7 +1165,9 @@ place_config_template() {
fi
if [[ "$need_place" == "1" ]]; then
if [[ -f "$config_path" ]]; then
local backup="${config_path}.bak.$(date +%s 2>/dev/null || echo 0)"
# bash 3.2（macOS 自带）在 set -eu 下对 `local var=$(cmd)` 有已知坑，
# 故 backup 已在上面预绑定为空串，这里用 $$.$RANDOM（始终有值、无命令替换）拼后缀。
backup="${config_path}.bak.$$.${RANDOM:-0}"
cp "$config_path" "$backup"
ui_warn "openclaw.json $reason → 用 template 覆盖（旧文件备份到 $backup）"
else
Expand Down