fix(security): harden exec permissions and remove dangerous defaults#439
Closed
OliviaPp8 wants to merge 1 commit into
Closed
fix(security): harden exec permissions and remove dangerous defaults#439OliviaPp8 wants to merge 1 commit into
OliviaPp8 wants to merge 1 commit into
Conversation
Security improvements: - Keep command substitution ( and backticks) blocked in patch 001 - Change IT Engineer from security:full to security:allowlist - Add IT Engineer exec-approvals.json with comprehensive sysadmin commands - Enable ask:on-miss for IT Engineer (user confirmation for unlisted commands) - Remove browser.ssrfPolicy.dangerouslyAllowPrivateNetwork from defaults - Remove tools.web.fetch.ssrfPolicy.allowRfc2544BenchmarkRange from defaults - Add docs/SECURITY.md documenting the security model Rationale: - Command substitution allows arbitrary code execution bypass - security:full with ask:off is dangerous under prompt injection - Private network access enables SSRF attacks on internal services Breaking changes: - IT Engineer may now prompt for confirmation on some commands - Browser cannot access private IPs by default (add back if needed)
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several security concerns identified in a code audit:
Changes
Restore command substitution blocking in patch 001
*Change IT Engineer from \security: full\ to \security: allowlist*
Remove dangerous browser defaults
Add security documentation
Rationale
Breaking Changes
Testing
/cc @MilkWind