ci: add GitHub Actions pipeline for Symfony smoke checks and fix test session config#5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
framework.session.storage_idwas deprecated and caused failures when running test commands.Description
.github/workflows/ci.ymlthat installs PHP (8.2), caches dependencies, runscomposer install, and executes Symfony smoke checks includingcomposer validate --strict --no-check-publish,php bin/console --version,php bin/console about,php bin/console lint:container,php bin/console lint:yaml config --parse-tags,APP_ENV=dev php bin/console lint:twig templatesandphp bin/console router:match /en.storage_id: session.storage.mock_filewithstorage_factory_id: session.storage.factory.mock_fileinconfig/packages/test/framework.yamlto be compatible with Symfony 6.4 session options.composer.jsonandcomposer.lock) as part of the dependency refresh (Symfony components and related packages reflect 6.4+ versions in the lockfile changes included in this rollout).Testing
composer validate --strict --no-check-publishwhich succeeded.php bin/console --version,php bin/console about,php bin/console lint:container,php bin/console lint:yaml config --parse-tags,APP_ENV=dev php bin/console lint:twig templates, andphp bin/console router:match /en, all of which completed successfully.php bin/console doctrine:migrations:migrate --env=testandphp bin/console doctrine:schema:create --env=test, which completed (migrations applied and schema created); fixtures load required re-creation of an empty test DB and then ran but later hit a NOT NULL constraint during one fixtures run../bin/phpunit --filter BlogControllerTest::testIndex) which executed but reported 1 failing test (HTTP 404 response) and several deprecation notices; this failure is unrelated to the CI pipeline itself and reflects an application-level test expectation to investigate further.Codex Task