Skip to content

Add amplitude damping noise model for density-matrix simulation#533

Closed
has9sayed wants to merge 1 commit into
TeamGraphix:masterfrom
has9sayed:amplitude
Closed

Add amplitude damping noise model for density-matrix simulation#533
has9sayed wants to merge 1 commit into
TeamGraphix:masterfrom
has9sayed:amplitude

Conversation

@has9sayed

Copy link
Copy Markdown

Before submitting, please check the following:

  • Make sure you have tests for the new code and that test passes (run nox)
  • If applicable, add a line to the [unreleased] part of CHANGELOG.md, following keep-a-changelog.
  • Format added code by ruff
    • See CONTRIBUTING.md for more details
  • Make sure the checks (github actions) pass.

Then, please fill in below:

Context (if applicable):
Description of the change:

Added amplitude damping as a built-in noise model in Graphix, following the same structure as DepolarisingNoiseModel. It introduces single- and two-qubit Kraus channels, AmplitudeDampingNoise / TwoQubitAmplitudeDampingNoise, and AmplitudeDampingNoiseModel, with exports at the package level.

Related issue:
Closes: #497

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.78947% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.87%. Comparing base (8bf1ebe) to head (5031397).

Files with missing lines Patch % Lines
graphix/noise_models/amplitude_damping.py 89.39% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   88.85%   88.87%   +0.01%     
==========================================
  Files          49       50       +1     
  Lines        7135     7210      +75     
==========================================
+ Hits         6340     6408      +68     
- Misses        795      802       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pranav97nair

Copy link
Copy Markdown

Thanks for your contribution. As you may have noticed, two other pull requests (#529 and #530) already address the same issue.

Of course, the definition of the noise classes is straightforward, and the more interesting part is writing the test functions to ensure accurate simulation of the new noise model. In this respect, could you clarify how your contribution differs from, or improves upon, the previous works? In particular, please explain why you consider your approach to be better.

You may of course update your submission if you wish!

@has9sayed has9sayed closed this Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement amplitude damping noise model

2 participants