Skip to content

ML - #19

Open
chorongi wants to merge 31 commits into
mainfrom
ML
Open

ML#19
chorongi wants to merge 31 commits into
mainfrom
ML

Conversation

@chorongi

@chorongi chorongi commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Merging

  1. ML inference
  2. ML trainer for t5
  3. default training config for t5
    added.

@chorongi chorongi changed the title Ml ML Aug 9, 2022
Comment thread .gitignore
model_dev/models/*

# pycache
model_dev/__pycache__/

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 그냥 __pycache__/ 이렇게만 써도 전부 ignore 돼 :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오케 그리하도록 하겠으

ㄳㄳ 밑에 커맨드 돌리고 다시 업데이트할께

@sungho-cho

Copy link
Copy Markdown
Contributor

혁재 gitignore에 __pycache__에 추가하는 거랑 별개로
PR에 포함된 파이캐시들이 좀 있는 것 같은데
git rm --cached {files or folders} 써서 지워줄 수 있어?

Comment thread model_dev/configs/wikihow_t5.yaml Outdated
batch_size: 2
gradient_accumu_steps: 8

eval: No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this yaml file missing something?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the eval part of the config is not yet implemented so didn't add anything else there yet but I'll remove before I make my updated pr

@junhur

junhur commented Aug 13, 2022

Copy link
Copy Markdown
Contributor

I didn't realize there was a working PR. I just pushed some merge conflict traces in example.py and .yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants