Skip to content

feat(auth): add GitHub OAuth login#44

Merged
hwangjokim merged 2 commits into
mainfrom
feat/43-github-oauth-login
May 11, 2026
Merged

feat(auth): add GitHub OAuth login#44
hwangjokim merged 2 commits into
mainfrom
feat/43-github-oauth-login

Conversation

@hwangjokim
Copy link
Copy Markdown
Member

Summary

  • Add the GitHub OAuth login button and backend OAuth entry URL config
  • Add the GitHub OAuth callback route with automatic code exchange for existing users
  • Add first-time GitHub user level onboarding plus MSW/OpenAPI/docs updates

Validation

  • pnpm typecheck: pass
  • pnpm biome lint .: pass
  • pnpm build: pass (Node 20.15.0 version warning and Vite chunk-size warning only)

Closes #43

@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
client Ready Ready Preview, Comment May 11, 2026 0:58am

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c880ff9ad2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/lib/api/config.ts
@hwangjokim hwangjokim merged commit bda747d into main May 11, 2026
3 checks passed
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e62fbddd52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +142 to +145
<Button
disabled={isExchangePending || Boolean(levelError)}
size="lg"
type="submit"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add a restart path for failed onboarding exchanges

When onboardingRequired=true, a 4xx/5xx response from /oauth/github/token leaves users with only the same submit action, which reuses the original OAuth code. Because authorization codes are short-lived/single-use, this branch can trap users in a non-recoverable loop unless they manually edit the URL or navigate away. Please offer an explicit way to restart from /login (or re-initiate OAuth) in the onboarding error state, like the non-onboarding branch already does.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(auth): add GitHub OAuth login

1 participant