Reconstruct product UI and real-mode UX#39
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hwangjokim
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: db3fbf20c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| label="현재 팀" | ||
| tone="primary" | ||
| trend={demoTeamSpace.nextMeetingLabel} | ||
| value="1" | ||
| /> |
There was a problem hiding this comment.
When a user is logged in, this always renders demoTeamSpace values (nextMeetingLabel, fixed team count, and later team name/project) regardless of API mode or actual team membership. In VITE_API_MODE=real, users without a team will still see fake “current team” data, which is a production-facing data integrity issue and contradicts the mock-only preview behavior introduced elsewhere in this commit.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc90fbb7c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const isSignedIn = Boolean(getAuthSession()); | ||
|
|
||
| function handleLogout() { | ||
| clearAuthSession(); |
There was a problem hiding this comment.
handleLogout removes only the auth token, but it does not clear React Query cache for authenticated data. Because useCurrentUserQuery is enabled: Boolean(getAuthSession()), after logout it stops refetching yet can still return cached /users/me data, so visiting /me in the same tab can show the previous user's profile despite being logged out. Please clear/remove auth-scoped queries on logout (the same pattern is also present in site-header.tsx).
Useful? React with 👍 / 👎.
| ); | ||
| const isSubmitDisabled = | ||
| !isSignedIn || | ||
| hasAcceptedTeam || |
There was a problem hiding this comment.
The submit/cancel gating now depends on hasAcceptedTeam, but that flag is derived only from local offerStatus (set by the preview panel) rather than server match state. In mock mode, a user can open “매칭 제안 미리보기” and click “수락”, which flips offerStatus to accepted and permanently disables new requests/cancel in this session even when no team was actually created. This makes the matching flow get stuck until a page reload.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
Closes #38