Skip to content

docker-compose env_file 추가 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chungjeongsu merged 1 commit into from
Apr 7, 2026
Merged

docker-compose env_file 추가 #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ services:
image: ${IMAGE_NAME:-ghcr.io/team-triple/triple_yjs}:${IMAGE_TAG:-develop}
ports:
- "1234:1234"
env_file:
- .env
environment:
PORT: "1234"
SECONDARY_JWT_SECRET: "change-me"
Y_LEVELDB_PATH: "/data/y-leveldb"
MAX_USERS_PER_ROOM: "20"
Comment on lines +6 to 11

@gemini-code-assist gemini-code-assist Bot Apr 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

현재 environment 섹션에 일부 값이 하드코딩되어 있어 .env 파일에 동일한 변수를 정의하더라도 무시되는 구조입니다 (Docker Compose에서 environment 섹션은 env_file보다 우선순위가 높습니다). 또한 필수 변수인 SECONDARY_JWT_SECRET이 명시되지 않아 가독성이 떨어집니다. 아래와 같이 변수 참조 방식을 사용하면 .env를 통한 유연한 설정이 가능해지며, 필요한 환경 변수 목록을 명확히 파악할 수 있습니다.

    env_file:
      - .env
    environment:
      PORT: "${PORT:-1234}"
      SECONDARY_JWT_SECRET: "${SECONDARY_JWT_SECRET}"
      Y_LEVELDB_PATH: "${Y_LEVELDB_PATH:-/data/y-leveldb}"
      MAX_USERS_PER_ROOM: "${MAX_USERS_PER_ROOM:-20}"

volumes:
Expand Down
Loading