Skip to content

CI 및 브랜치별 CD 배포 파이프라인 정리#20

Merged
chungjeongsu merged 1 commit into
mainfrom
feat/ci-cd
Apr 1, 2026
Merged

CI 및 브랜치별 CD 배포 파이프라인 정리#20
chungjeongsu merged 1 commit into
mainfrom
feat/ci-cd

Conversation

@chungjeongsu

Copy link
Copy Markdown
Contributor

No description provided.

@chungjeongsu chungjeongsu self-assigned this Apr 1, 2026
@chungjeongsu chungjeongsu merged commit 0c97ea0 into main Apr 1, 2026
2 checks passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docker-compose.yml file to use a pre-built image instead of building from the local Dockerfile. The review feedback suggests retaining the build configuration alongside the image property to maintain flexibility for local development while still supporting CI/CD image overrides.

Comment thread docker-compose.yml
build:
context: .
dockerfile: Dockerfile
image: ${IMAGE_NAME:-ghcr.io/team-triple/triple_yjs}:${IMAGE_TAG:-develop}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

로컬 개발 환경에서의 편의성을 위해 build 설정을 유지하는 것을 권장합니다. buildimage를 함께 정의하면, 로컬에서는 docker-compose up --build를 통해 소스 코드 변경 사항을 즉시 반영하여 테스트할 수 있으며, 동시에 CI/CD 환경에서는 환경 변수를 통해 주입된 이미지 이름을 사용할 수 있어 유연성이 높아집니다.

    build:
      context: .
      dockerfile: Dockerfile
    image: ${IMAGE_NAME:-ghcr.io/team-triple/triple_yjs}:${IMAGE_TAG:-develop}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant