Skip to content

Transfer 엔티티 totalAmount 불변식 음수만 안되게 수정 #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chungjeongsu merged 2 commits into from
May 26, 2026
Merged

Transfer 엔티티 totalAmount 불변식 음수만 안되게 수정 #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a541b49
[#233] fix: Transfer 엔티티 totalAmount 불변식 음수만 안되게 수정
chungjeongsu May 26, 2026
d415cdc
[#233] fix: Transfer 엔티티 totalAmount 불변식 음수만 안되게 수정에 따른 테스트 수정
chungjeongsu May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/triple/backend/transfer/domain/Transfer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ private String validateText(final String value, final String fieldName) {
}

private BigDecimal validateTotalAmount(final BigDecimal value) {
if (value.compareTo(BigDecimal.ZERO) <= 0) {
throw new IllegalArgumentException("totalAmount must be greater than zero");
if (value.compareTo(BigDecimal.ZERO) < 0) {
throw new IllegalArgumentException("totalAmount must be greater than minus");
Comment on lines +131 to +132

@gemini-code-assist gemini-code-assist Bot May 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

예외 메시지인 "totalAmount must be greater than minus"는 영문법상 어색하며 의미가 모호합니다. 음수를 허용하지 않는다는 의도를 명확히 하기 위해 "totalAmount must be non-negative" 또는 "totalAmount must be greater than or equal to zero"로 변경하는 것이 좋습니다.

또한, 이 변경으로 인해 기존 TransferTest.java의 changeTotalAmount_zeroOrNegative_throws 테스트(금액이 0일 때 예외 발생을 검증하는 테스트)가 실패하게 됩니다. 테스트 코드도 이번 변경 사항에 맞춰 함께 수정해 주세요.

Suggested change
if (value.compareTo(BigDecimal.ZERO) < 0) {
throw new IllegalArgumentException("totalAmount must be greater than minus");
if (value.compareTo(BigDecimal.ZERO) < 0) {
throw new IllegalArgumentException("totalAmount must be non-negative");
}

}
return value;
}
Expand Down
9 changes: 5 additions & 4 deletions src/test/java/org/triple/backend/transfer/domain/TransferTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,13 @@ void changeAccountHolder_blank_throws() {
}

@Test
@DisplayName("changeTotalAmount는 0 이하 금액이면 예외를 던진다")
void changeTotalAmount_zeroOrNegative_throws() {
@DisplayName("changeTotalAmount는 0을 허용하고 음수 금액이면 예외를 던진다")
void changeTotalAmount_allowsZeroAndRejectsNegative() {
Transfer transfer = transfer();

assertThatThrownBy(() -> transfer.changeTotalAmount(BigDecimal.ZERO))
.isInstanceOf(IllegalArgumentException.class);
transfer.changeTotalAmount(BigDecimal.ZERO);

assertThat(transfer.getTotalAmount()).isEqualByComparingTo(BigDecimal.ZERO);
assertThatThrownBy(() -> transfer.changeTotalAmount(new BigDecimal("-1")))
.isInstanceOf(IllegalArgumentException.class);
}
Expand Down
Loading