TransferUpdateRequestDto PositiveOrZero로 불변식 변경#232
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TransferUpdateRequestDto to allow a totalAmount of zero by changing the validation annotation to @PositiveOrZero. Feedback highlights a discrepancy between this DTO change and the domain entity's validation logic, which still prohibits zero values. Additionally, a typo in the validation error message was noted, incorrectly referring to 'member amount' instead of 'totalAmount'.
| String bankName, | ||
| String accountHolder, | ||
| @Positive(message = "totalAmount must be greater than zero") | ||
| @PositiveOrZero(message = "member amount must be greater than or equal to zero") |
There was a problem hiding this comment.
DTO에서 totalAmount에 대해 0을 허용하도록(@PositiveOrZero) 변경하셨으나, Transfer 도메인 엔티티의 validateTotalAmount 메서드(131라인)에서는 여전히 0 이하의 값을 허용하지 않고 있습니다. 불변식을 0을 포함하도록 변경하는 것이 의도라면, 도메인 엔티티의 유효성 검사 로직도 함께 수정해야 런타임 에러를 방지할 수 있습니다.
| String bankName, | ||
| String accountHolder, | ||
| @Positive(message = "totalAmount must be greater than zero") | ||
| @PositiveOrZero(message = "member amount must be greater than or equal to zero") |
There was a problem hiding this comment.
totalAmount 필드에 대한 검증 메시지가 member amount로 잘못 작성되어 있습니다. 필드명에 맞게 totalAmount로 수정하는 것이 적절합니다.
| @PositiveOrZero(message = "member amount must be greater than or equal to zero") | |
| @PositiveOrZero(message = "totalAmount must be greater than or equal to zero") |
1 participant
No description provided.