travel-detail 가독성 위한 리팩토링#230
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the group detail retrieval logic by consolidating data access from multiple repositories into a centralized custom repository using Querydsl. This change simplifies the GroupUseCase and updates the GroupDetailRes DTO to handle the new data structure. Feedback suggests using explicit joins in Querydsl for better query plan predictability and considering query consolidation techniques, such as Querydsl's Transform, to reduce the number of database round-trips.
| .from(travelReviewImage) | ||
| .join(travelReviewImage.travelReview, travelReview) | ||
| .where( | ||
| travelReview.travelItinerary.group.id.eq(groupId), |
Contributor
There was a problem hiding this comment.
암시적 조인(Implicit Join)보다는 명시적 조인(Explicit Join)을 사용하는 것이 쿼리 실행 계획을 예측하기에 더 좋습니다. travelReview.travelItinerary에 대해 명시적 조인을 추가하는 것을 고려해 보세요.
.join(travelReviewImage.travelReview, travelReview)
.join(travelReview.travelItinerary, travelItinerary)
.where(
travelItinerary.group.id.eq(groupId),
travelReview.isDeleted.isFalse()
)
Comment on lines
+108
to
+113
| int travelCount = Math.toIntExact(groupJpaRepository.countTravels(groupId)); | ||
| List<RecentTravelDto> recentTravels = myRole == Role.GUEST | ||
| ? List.of() | ||
| : groupJpaRepository.findRecentTravels(groupId, DETAIL_RECENT_SIZE); | ||
| List<RecentReviewDto> recentReviews = groupJpaRepository.findRecentReviews(groupId, DETAIL_RECENT_SIZE); | ||
| List<RecentPhotoDto> recentPhotos = groupJpaRepository.findRecentPhotos(groupId, DETAIL_RECENT_SIZE); |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.