-
Notifications
You must be signed in to change notification settings - Fork 0
추천 기능 구현 및 모듈 이전으로 인한 수정을 진행합니다. #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
39362ed
fix/#339: AppCoordinator 타입 불일치 수정 (AppCoordinator -> AppCoordinatorP…
dongglehada 66e674c
fix/#339: 추천 기능 DTO 이중 래핑 제거 및 에러 로깅 추가
dongglehada c213889
feat/#339: 추천 화면 비로그인 상태 뷰 및 수정하기 네비게이션 추가
dongglehada 3a0f337
feat/#339: 추천 화면 헤더 검색/알림 버튼 네비게이션 추가
dongglehada 5bd524c
refactor/#339: LoginExitRoute를 MLSAppFeatureInterface에서 MLSCore로 이동
dongglehada 620125f
feat/#339: 추천 화면 북마크 기능 구현
dongglehada 2404af2
feat/#339: 탭바 자동 숨김 처리 (push 시 숨김, root 복귀 시 표시)
dongglehada 56748f4
fix/#339: MLSDesignSystem SPM 모듈 에셋 번들 참조 오류 수정 및 탭바 배경 추가
dongglehada c88f23b
feat/#339: 앱 버전 업데이트 체크 및 얼럿 구현
dongglehada 27defeb
style/#339: Apply SwiftLint autocorrect
github-actions[bot] 93ef498
fix/#339: 도감 상세 도감 버튼 탭 이동 인덱스 수정 (추천→도감)
dongglehada 18c0c4d
fix/#339: 캐릭터 수정 화면 기존 레벨/직업 데이터 미입력 수정
dongglehada e8e7e1f
fix/#339: 프로필 이미지 선택 모달 열릴 때 탭바 재노출 수정
dongglehada ea8aeb9
fix/#339: 프로필 닉네임 수정 취소 시 미저장 값이 표시되는 문제 수정
dongglehada f03ca2f
fix/#339: 강제 업데이트 옵저버 중복 등록으로 인한 메모리 누수 수정
dongglehada 2971e33
fix/#339: 북마크 버튼 연속 탭 시 중복 API 요청 방지
dongglehada 0ab1485
fix/#339: 프로필 이미지 선택 모달 닫힐 때 탭바 재노출 수정
dongglehada 2dcb87b
fix/#339: 프로필 이미지 즉시 저장 제거, 완료 버튼에서 닉네임+이미지 함께 저장 및 편집 모드 종료
dongglehada 32b3b93
fix/#339: 프로필 편집 모드 진입 시 완료 버튼 동작 불가 수정 및 뒤로가기 버튼 숨김 처리
dongglehada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| enum AppInfo { | ||
| // TODO: 앱스토어 출시 후 실제 앱 ID로 교체 | ||
| static let appStoreID = "6477212894" | ||
| static let appStoreURL = "itms-apps://itunes.apple.com/app/id\(appStoreID)" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 8 additions & 1 deletion
9
...SAppFeature/Sources/MLSAppFeatureInterface/Domain/Navigation/AppCoordinatorProtocol.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,15 @@ | ||
| import MLSCore | ||
| import UIKit | ||
|
|
||
| @MainActor | ||
| public protocol AppCoordinatorProtocol: AnyObject { | ||
| var window: UIWindow? { get set } | ||
| func showMainTab() | ||
| func showMainTab(selectedIndex: Int) | ||
| func showLogin(exitRoute: LoginExitRoute) | ||
| } | ||
|
|
||
| public extension AppCoordinatorProtocol { | ||
| func showMainTab() { | ||
| showMainTab(selectedIndex: 0) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
MLS/MLSAuthFeature/Sources/MLSAuthFeatureInterface/Factories/LoginFactory.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import MLSAppFeatureInterface | ||
| import MLSCore | ||
|
|
||
| public protocol LoginFactory { | ||
|
|
||
2 changes: 0 additions & 2 deletions
2
...ce/Domain/Navigation/LoginExitRoute.swift → ...ources/MLSCore/Utils/LoginExitRoute.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| import UIKit | ||
|
|
||
| public enum LoginExitRoute { | ||
| case pop | ||
| case home | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NotificationCenter의 블록 기반
addObserver는 반환된 옵저버 토큰을 명시적으로 제거하지 않으면 메모리 누수가 발생할 수 있습니다.AppLauncher가 해제되거나 새로운 옵저버를 등록하기 전에 기존 옵저버를NotificationCenter.default.removeObserver를 통해 제거해주는 것이 안전합니다.